Repository navigation
Fix the flaky health report size test - #375
Merged
Merged
Conversation
…bytes The report line is about 199-200 bytes and its length changes with the process number and other numbers, so the old fixed limit failed now and then. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 of 4 tasks
txoof
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #374
What changed
The test
test_report_is_replaced_and_never_growsfailed now and then. It checked that the health file stays under 200 bytes, but one report line is already about 199–200 bytes, and its length changes with the process number and other numbers. The test now writes one report, notes the file's size, writes 199 more, and checks that the file is at most 10 bytes bigger than that first size. It still checks that the file is one line and that no temporary files are left.This fix was meant to go into #373, but #373 was merged before it was pushed.
Area
core (tests only:
tests/test_health.py)Tests
uv run pytest tests/test_health.pypasses (3 runs in a row; also 5 runs on the met_no: six layouts that are easy to read from a distance #373 branch)uv run ruff check .passesReview
Only txoof approves and merges this PR.
🤖 Generated with Claude Code